]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
authPrompt: disassociate from userVerifier when destroyed
authorRay Strode <rstrode@redhat.com>
Mon, 29 Jul 2013 17:24:36 +0000 (13:24 -0400)
committerRay Strode <rstrode@redhat.com>
Thu, 1 Aug 2013 20:08:22 +0000 (16:08 -0400)
Otherwise, it won't get GC'd and we'll end up potentially calling
its signal handlers after destruction.

https://bugzilla.gnome.org/show_bug.cgi?id=683437

js/gdm/authPrompt.js

index 0666294fec8647ce8bc1b519e8d9092ac74468a0..6b2480b1bcc017e1423c8c71c09c99de62d5026b 100644 (file)
@@ -123,6 +123,8 @@ const AuthPrompt = new Lang.Class({
 
     _onDestroy: function() {
         this._userVerifier.clear();
+        this._userVerifier.disconnectAll();
+        this._userVerifier = null;
     },
 
     _initButtons: function() {